Readable corrupt zips that require fixes cause repeated errors

RV 3.5.2

Logic Issue
j

johnsanc

2 years ago

If a zip file is corrupt but readable, and the archive needs fixing (E.g. deletions of matched files), then RomVault will throw an error while fixing. This error will occur during every fix run as RomVault will keep attempting to fix the corrupt archive.


Steps to reproduce:

  1. Place a corrupt archive in your ToSort that is readable where some files can be extracted but others cannot

  2. Place a DAT in your DATRoot that should match some of the files in the corrupt archive

  3. Update DATs

  4. Scan the corrupt archive

  5. Find fixes and fix ROMs

  6. An error will occur when RomVault tries to delete files from the archive

  7. Attempt to fix again, and notice the same error will occur


Expected behavior:

  • Suggestion: RomVault should not attempt to delete any files from corrupt archives since there are likely issues that would prevent recompressing the archive


Contact johnsanc for example archive.

(screenshot)

Activity

G

GordonJ changed the status to WIP Testing

2 years ago

G

GordonJ

2 years ago

Fixed in V3.5.1 WIP2

G

GordonJ changed the status to RV 3.5.2

2 years ago


Powered by Convas