Feedback - Bugs & Issues

The fixing progress bar and percentage indicator do not seem to account for the "Compress" action. Steps to reproduce: Add some zips and a few large uncompressed files to ToSort which are needed for a fix. The issue is easiest to identify if the uncompressed files will be last to be fixed. Scan, Find, Fix Notice that the progress bar and percentage will say 100% before all of the uncompressed files are compressed to their final destination

CHD verification cannot be cancelled

Reproducible

Cancelling a scan does not stop verification of the current CHD. A scan cancellation should immediately stop the CHD verification process. Steps to reproduce: Place a large CHD file in a ToSort Start a scan of the ToSort Immediately try to stop the scan Notice that RV still continues to decompress and hash the chd and will not cancel the scan until its complete.

RV should halt if a path is inaccessible

Reproducible

Network File Error

If a path becomes inaccessible during a scan (E.g. mapped network drive), RV will continue to scan and erase information of previously scanned files. Steps to reproduce: Start with a fresh RV instance Map a network drive and assign it as a ToSort. Reproducing this issue works best if the ToSort contains a lot of files and directories. Scan the mapped network drive ToSort After the scan is complete, start the scan again and quickly disconnect the mapped network drive as RV is traversing directories Notice that RomVault will continue the scan without error but will erase any previously scanned info for future directories leaving only empty directory references in the cache.

7z cache grows too large

WIP Testing

With RV 3.7.0 the 7z cache seems to fill up without any deletions. One user reported a 7z cache that grew to over 700 GiB. The files in the 7z cache should be deleted after the archive they are needed for has been written.

Sorting resets during a fix

Reproducible

General UX

When RomVault is fixing, the sort order of the ROM Details and Game List grids keep resetting every few seconds. This behavior makes browsing your collection difficult when a fix is running. The user-specified sort order should persist while a fix is running. Steps to Reproduce: Add the Sony PS3 redump DAT and set the rules to use Single Archive without subdirs so that the dat contents are predominately displayed in the rom details grid Start a fix that should take a few minutes to complete (to be able to have enough time to reproduce the issue) Navigate to the PS3 dat in the tree and try to scroll the rom details grid to view set content - notice the grid snaps back to the top every few seconds Try to sort by various columns in the rom details grid - notice the sorting resets every few seconds.

Linux and Windows cache seem to use the same directory separators

Need Info

Core

Linux

copying cache from a windows to linux machine still gives backward slashes. so it seems those are hardcoded

Crash occurs when attempting to delete a file open by another process

Reproducible

RomVault will hard crash during a fix when it attempts to delete a file open by another process. The error is: "The process cannot access the file XXXXX because its being used by another process". When this occurs the cache becomes out of sync with the filesystem and the user must rescan after closing and reopening RomVault. Steps to reproduce: Put a .bin file in your ToSort directory Load a DAT that requires that .bin file Mount the .bin file in Daemon tools so it is locked by that process. Scan, Find, Fix RomVault will crash on the deletion attempt of the .bin file

Incorrect "Scanning Dirs" percentage in window title when scanning

Reproducible

When I scan my "To Scan" directory the window title of the progress dialog shows "Scanning Dirs - 100% complete". But it just started, it is not 100% complete and therefore confusion when looking at the title in the Windows taskbar it would help if I see values like 75% or 90%. Or no percentage value. It is for sure a minor, more or less cosmetic bug... Suggested solutions (if I did not misunderstood the intention): 1) Just show "Scanning Dirs" or "Scanning Dirs - in progress..." 2) Update the title with the correct percentage value each time the value increases 3) Show instead the current dir name that is currently scanned, e.g. "Scanning dir: To Sort" with a relative (short) path that might work... Steps to reproduce: Scan a ToSort directory with many subdirs Notice as its scanning the title bar says 100% complete

Scanning progress window does not show accurate scanning position

Reproducible

The scanning progress window shows statistics in the upper right corner. This statistic shows the position of the last file scanned in relation to the total number of files in the directory. This is not a useful metric because many files in the directory may already be scanned. Ideally this metric should be: "Number of files scanned including the current file" / "Total files that need to be scanned in the directory" Note in this case "scan" is described as files that need to be hashed because they are either new or their timestamps have changed compared to the RV cache. Steps to reproduce: Start a scan across your RomRoot and ToSort directories on your primary instance of RV Watch the scanning window carefully and note the file progress counter, it is not intuitive to the user and does not appear reflective of what is actually happening

If a fix only consists of removals to ToSort, the percentage complete and progress bar stay at 0%

Reproducible

Steps to reproduce: Start with a fresh RV instance Place some files that do not match any dat in your romroot Scan files Find and fix Notice the progress percentage does not update for any removals to ToSort

Crash occurs with “unexpected network error” when a mapped network drive experiences latency

Cannot Reproduce

Network File Error

If a mapped network drive is under heavy load, spun down, or otherwise has excessive latency, then RV will crash during a fix targeting that network drive. Steps to reproduce: Introduce excessive latency to a mapped network drive (Unsure the best way to do this consistently, but the error was observed when there was a heavy network load, it maybe possible to reproduce by disabling your network adapter or unmounting the drive in the middle of the fix) Perform a fix that targets the network drive A crash will occur if the latency is too great Expected behavior: RomVault should display a halting error and update the cache (screenshot)

Partial sets are unexpectedly built with certain DAT settings

Reproducible

Settings

Using the following DAT settings, RV will create partial sets during a fix which is not expected: Archive Type: File Single Archive: No Subdirs (or conflicts only) Keep Only Complete Sets: Enabled In this case, when a user is using the "File" archive type, they are likely wanting to prevent subdirectories and prevent storing discs with incomplete tracks.

Crash occurs when attempting to delete a file with insufficent permissions

Reproducible

RomVault will crash if it attempts to delete a file that is does not have permission to delete. The easiest way to reproduce this issue is with an unraid share: Setup RV with a dat and file that would match something in a ToSort that resides on an unraid share Ensure the owner of the file is nobody/users Change the permissions of the file to 0644 instead of the usual 0666 Scan and fix RV should crash when attempting to delete the file with 0644 permissions

Case sensitive deduped removals cause file not found error

Reproducible

There are cases where RV will associate the wrong character case file with a DAT. If the dat references a character case that is different from what is actually on the case-sensitive filesystem, when this file is removed due to a "not needed because deduped" scenario RV will error. Subsequent L2 scans do not correct the character case in the cache. File not found error: Light Cyan status indicating the deduped file is not needed there. Notice the upper case ASTRONEER text: Actual file on filesystem. Notice lowercase Astroneer text:

Hard crash doing Fix ROMs before Find Fixes

WIP Testing

RV will crash with an "object reference not set to an instance of an object" error under the following conditions: Add a DAT and scan a few roms for that DAT in their proper location so they are green status Open DAT settings and change the compression from the default of deflate to zstd, ensure "convert while fixing" is ticked After saving the dat settings, click fix roms without first doing find fixes. Notice RV crashes with an error similar to below

RV CMD displays UI related error messages during CHD scan

WIP Testing

RV CMD seems to display errors when scanning chds.

Excessive SMB chatter causes fix to stall

WIP Testing

Core

In some setups using Samba shares, RV seems to generate a significant amount of chatter which causes significant delays during fixing and can render RV essentially unusable on large collections. When using Wireshark, there is evidence that RV is also requesting directories and their ancestors that are not in scope. RV 3.7.1 WIP2 is the first build with this issue.

Logic error for DB found file does not match

WIP Testing

As of RV 3.7.2, some dats with non-standard characters cause an error during fixing. The error states: "Logic error trying to find the file we are fixing XXXXX DB found file does not match"

Make New Folder button enabled for Master Dirs in DatVault

WIP Testing

When adding new dats from DatVault, the the Make New Folder button is enabled even when Master Dirs is selected. The button should be disabled since the rest of the datroot tree is grayed out.

Crash if Cache ToSort unavailable

Reproducible

If the cache ToSort is unavailable, RV will crash when it is attempted to be used for fix. Steps to reproduce: Map a network drive and assign it as a cache ToSort Disconnect the network drive Scan a solid 7z archive that is also needed for a fix Find / Fix, and notice RV crashes when trying to write to the Cache ToSort

Crash due to illegal characters in path during fix

Need Info

RV will crash when a fix is performed on a file in an archive that has illegal characters in its path. In this case the double quote is invalid. When this archive is fixed, a crash occurs:

Category subdirs do not work properly on auto-created directories

Reproducible

Settings

The category subdirectories feature does not work when its applied to an auto-created datroot directory. Put multiple redump dats into a directory Apply the category subdirs setting on one of the dats Notice the category subdirs are not applied Refresh all dats and notice the settings are applied. Remove the dat rule and apply, and notice the settings remain Refresh all dats, and notice the settings are applied.

Zero byte files are extracted to 7z cache

WIP Testing

RV uses the 7z cache ToSort when a fix is needed from a solid 7z archive. Only the files necessary are stored in this 7z cache folder, however 0-byte files are also included. 0-byte files should not be extracted because there is no point since they can be created on the fly.

CHDs in archives do not record version flag

Reproducible

Scanning

When CHDs are packed in an archive, the CHD version is not recorded and shows as (CHD ) in the ROM details grid. This also means CHDs will be rehashed every scan if CheckCHDVersion is set to true in the config xml. Steps to reproduce: Add the setting CheckCHDVersion to your config XML and set it to true Download the EmuArc dat for Sega Chihiro from DatVault Set the DAT settings to ZIP Let RV fix the sets so that the CHDs are packed in zip archives Notice the CHD version tag is blank Scan the Chihiro collection again and notice that the archive contents are rehashed due to the missing CHD version

DatVault path2 value cannot be null

Cannot Reproduce

DATVault

A user running RV in an ARM Windows VM on a Mac reported that DatVault throws an error whenever a DV DAT update is triggered. The error occurs once the progress bar reaches 100%.

Headered roms do not use ZipMove

Reproducible

As of RV 3.7.0, headered roms are not zipmoved in scenarios where they could be. Any movements within the RomRoot, or from ToSort to RomRoot do not use ZipMove. Any movement from RomRoot to ToSort does use ZipMove properly. Note this does not appear to be related to matching on Alt hashes. Recent No-Intro headered DATs contain the full hashes of the headered ROMs. Example of a ROM that was not ZipMoved from the headered NES set. Steps to reproduce: Add the No-Intro headered DAT to your DATRoot Scan find and fix some NES headered ROMs so are moved into place according to the DAT Move the DAT to a new location in your DATRoot and update dats to register the location move Find and Fix and notice the the NES headered roms are not ZipMoved, instead they are copied and deleted.

Silent crash while navigating during a fix

Cannot Reproduce

RV will sometimes silently crash when navigating around the UI during a fix. This most commonly occurs with interactions with the Game List grid when drilling in and backing out of directories using the double click left/right navigation. RV does not show any error or crash report, but you can see crash info in Windows Event Viewer.

Debug Logging missing detailed fix info for files

Reproducible

As of RV 3.7.0 the debug log only contains info about which DAT rule is used. There is no detailed info about the fix. Steps to reproduce: Open RV 3.7.0+ Enable debug logging Place some uncompressed roms in ToSort Setup a DAT rule with the archive type set to "File". This dat should contain some of the roms in your ToSort Do a fix Check the debug log in the logs directory and notice it only shows DAT rules processed and there is no info about any fixes.

ROM Occurrence list shows orphaned NotGot reference

Cannot Reproduce

The ROM Occurrence list shows an extra NotGot entry with no path

Description and Name values are not cleansed when used for directories

Reproducible

Logic Issue

The description and name values in the DAT can sometimes have slashes in the value. When RV processes this with single archive settings or auto-directory naming it interprets the slashes as path separators and creates an unwanted sub-directory. Instead, RV should cleanse this value to a proper directory name. Steps to reproduce: Place two dats in a single directory in your datroot. Modify the name value of one of the dats in a text editor to add a forward slash somewhere in the name Update dats Notice that the forward slash is properly converted to a dash in the dat name, but this is not used for the single archive path

Single Archive DAT processing options crash with SuperDATs

Reproducible

The Single Archive DAT processing options can crash RomVault with an "Unable to cast object of type" error. Steps to reproduce: Add the TOSEC-Rollback dat from DatVault Change the DAT settings to Single Archive + Use subdirs for all sets Save the dat rule and notice RV crashes Example DAT Rule RomVault\Various\Rollbacks\TOSEC Zip false None KeepAll Optional false true KeepAllSubDirs false true false false

Value of "X" is not valid for "Value" error

Need Info

While fixing, RV can error when browsing the sets that are actively being fixed. The error appears to be related to a scrollbar value. When the error occurs the fix will continue and the error can be dismissed.

RomVault exits when using torrentzip and it it runs out of disk space

Open

Open TorrentZip from the "Help" menu Torrentzip a large file The disk its writing to runs out of space while torrentzipping Whole program just exists .. no exception is caught/logged.

The "Only Keep Complete Sets" setting does not work properly on Linux

Reproducible

Linux

The "Only Keep Complete Sets" setting does not apply correctly when using Linux with mono: Steps to Reproduce: Select the last folder in a tree and choose the "Only Keep Complete Sets" option (o a not complete set). Place some files that match some of the files in the folder but don't form a complete set into the ToSort directory. For example, add only the .cue file but not the .bin file. Find fixes. RonVault will mark some ROMs as missing and partially fix the sets in the directory. However, there is a workaround to address this issue. After marking the folder, select the parent folder with the same option, and then it seems to work correctly.

Crash/Exit when trying to create directory on un-mounted drive

Need Info

I use removable drives .. sometimes ill accidentally scan a dir that is not mounted .. looks like RV just needs a few extra little checks before trying to create a directory on an un-reachable drive. EXCEPTION: Source: mscorlib Message: Could not find a part of the path '\\?\L:\Handheld\Sony - PlayStation Portable'.STACK TRACE: at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath) at System.IO.Directory.InternalCreateDirectory(String fullPath, String path, Object dirSecurityObj, Boolean checkHost) at System.IO.Directory.InternalCreateDirectoryHelper(String path, Boolean checkHost) at RomVaultCore.FixFile.Util.FixFileUtils.CheckCreateDirectories(RvFile file) at RomVaultCore.FixFile.Util.FixFileUtils.CheckCreateDirectories(RvFile file) at RomVaultCore.FixFile.Util.FixFileUtils.CheckCreateDirectories(RvFile file) at RomVaultCore.FixFile.FixAZip.FixZip(RvFile fixZip, List`1 fileProcessQueue, Int32& totalFixed, String& errorMessage) at RomVaultCore.FixFile.Fix.FixBase(RvFile child, Boolean thisSelected, List`1 fileProcessQueue, Int32& totalFixed, Int32& reportedFixed, Stopwatch cacheSaveTimer) at RomVaultCore.FixFile.Fix.FixDir(RvFile dir, Boolean lastSelected, List`1 fileProcessQueue, Int32& totalFixed, Int32& reportedFixed, Stopwatch cacheSaveTimer) at RomVaultCore.FixFile.Fix.FixBase(RvFile child, Boolean thisSelected, List`1 fileProcessQueue, Int32& totalFixed, Int32& reportedFixed, Stopwatch cacheSaveTimer) at RomVaultCore.FixFile.Fix.FixDir(RvFile dir, Boolean lastSelected, List`1 fileProcessQueue, Int32& totalFixed, Int32& reportedFixed, Stopwatch cacheSaveTimer) at RomVaultCore.FixFile.Fix.FixBase(RvFile child, Boolean thisSelected, List`1 fileProcessQueue, Int32& totalFixed, Int32& reportedFixed, Stopwatch cacheSaveTimer) at RomVaultCore.FixFile.Fix.FixDir(RvFile dir, Boolean lastSelected, List`1 fileProcessQueue, Int32& totalFixed, Int32& reportedFixed, Stopwatch cacheSaveTimer) at RomVaultCore.FixFile.Fix.FixBase(RvFile child, Boolean thisSelected, List`1 fileProcessQueue, Int32& totalFixed, Int32& reportedFixed, Stopwatch cacheSaveTimer) at RomVaultCore.FixFile.Fix.FixDir(RvFile dir, Boolean lastSelected, List`1 fileProcessQueue, Int32& totalFixed, Int32& reportedFixed, Stopwatch cacheSaveTimer) at RomVaultCore.FixFile.Fix.FixBase(RvFile child, Boolean thisSelected, List`1 fileProcessQueue, Int32& totalFixed, Int32& reportedFixed, Stopwatch cacheSaveTimer) at RomVaultCore.FixFile.Fix.FixDir(RvFile dir, Boolean lastSelected, List`1 fileProcessQueue, Int32& totalFixed, Int32& reportedFixed, Stopwatch cacheSaveTimer) at RomVaultCore.FixFile.Fix.PerformFixes(ThreadWorker thWrk)

ZipMove while file is open results in "Check File Move Error"

Reproducible

If an archive is open while RomVault attempts to ZipMove it, an error will trigger and stop the fix. The error states: "Check File Move Error with FileSystemError". Steps to reproduce: Place a complete archive in a ToSort directory that is needed for a fix Keep the archive open, for example within 7zip file manager Find fixes, Fix ROMs RomVault will error when attempting to ZipMove Expected Behavior: RomVault should mark the archive as locked (blue status) and proceed with the rest of the fixes

Odd Behavior

Need Info

Appears to be UN-zipping and re-zipping same large zip file, in fix rom mode. No Dat... Folder was added as an unlocked to-sort directory on a separate drive. File is large zip with folders containing smaller zips. Possibly converting file from zip to 7z? If so, it is doing this unprompted and on a separate drive/folder than the set RomRoot folder.

Browsing subfolders in a ToSort during a scan/fix will change the DAT Info panel back to the root of the ToSort every few seconds

Reproducible

Steps to Reproduce: Start a scan Navigate a ToSort by drilling into directories in the Game List grid Notice the DAT info panel reverts back to the root ToSort directory every few seconds instead of showing the info about the directory you are currently viewing

Crash occurs when RV tries to do a fix from a path that is no longer accessible due to a case sensitivity difference

Need Info

Case Sensitivity Issue

In general Windows is not case sensitive, but users can have setups with SMB shares that are case sensitive. This can result in situations where a path is inaccessible or its contents unexpected due to case sensitivity differences. Steps to reproduce: See discord for details: https://discord.com/channels/619198661838241795/870048528112697344/992569737995370546 If the information in Discord is not sufficient, contact johnsanc Expected behavior: Handle case sensitivity conflicts gracefully with a halting error and cache update (screenshot 1, 2)

A vague error can occur when there are unscanned files using File archive type in your RomRoot and a fix tries to move files of the same name into place

Reproducible